Skip to content

[Sema/Tests] NFC: Limit a couple of perf tests to macOS #63826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Feb 22, 2023

Helps to avoid flakiness on simulators/devices.

Resolves: rdar://105752467

Helps to avoid flakiness on simulators/devices.

Resolves: rdar://105752467
@xedin
Copy link
Contributor Author

xedin commented Feb 22, 2023

I think we need to update all of the perf tests to macOS only but let's start with these two.

@xedin
Copy link
Contributor Author

xedin commented Feb 22, 2023

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Feb 22, 2023

@swift-ci please smoke test Linux platform

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Feb 22, 2023

@swift-ci please smoke test Linux platform

@xedin xedin merged commit 756523e into swiftlang:main Feb 23, 2023
@glessard
Copy link
Contributor

Thanks @xedin.
Should we require OS=macOS || OS=linux? (and possibly || OS=windows...)
Should we do the same for all the performance-related type-checker validation tests? I see that rdar22466245.swift was afflicted by the same issue in the meantime.

@xedin
Copy link
Contributor Author

xedin commented Feb 23, 2023

I think macOS is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants