[cxx-interop] Provide a support header for common attributes, etc. #63839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please Build Toolchain macOS Platform |
egorzhdan
reviewed
Feb 22, 2023
lib/ClangImporter/cxx-interop.h
Outdated
| __attribute__((swift_attr(_CXX_INTEROP_STRINGIFY(retain:_retain)))) \ | ||
| __attribute__((swift_attr(_CXX_INTEROP_STRINGIFY(release:_release)))) | ||
|
|
||
| #define SWIFT_NAME(_name) __attribute__((swift_name(#_name))) |
There was a problem hiding this comment.
I don't think SWIFT_NAME belongs here: it isn't specific to C++ interop, it is also used for C/ObjC interop. On Darwin there's an existing macro for this (NS_SWIFT_NAME), is this a replacement for NS_SWIFT_NAME?
There was a problem hiding this comment.
I was thinking more about non-darwin platforms or users that don't have access to or don't want to use Foundation (the place this macro is currently provided).
|
@swift-ci Please Build Toolchain macOS Platform |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.