[Sema] Fix variable invalid optional chaining in if context diagnostic #63845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In constraint generation a
RemoveUnwrap
is recorded when addingOptionalObject
forBindOptionalExpr
but when adding contextual constraint and attempting to add the contextual conversion constraint we end up in attemptingrepairViaOptionalUnwrap
which succeed because there is aRemoveUnwrap
already but returnsfalse
because the fix was recorded on a previous constraint and is not onconversionsAndFixes
list. This leaves the conversion constraint asfailedConstraint
and solver stops without being able to form a solution and produce diagnostic.The fix is simply assume that if
repairViaOptionalUnwrap
is successful we assume fixed inrepairFailure
already because it either record a fix or bail because there is a fix already.Resolves #63796