Skip to content

[cxx-interop] Build the C++ stdlib overlay when SWIFT_BUILD_SDK_OVERLAY=NO #63865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

egorzhdan
Copy link
Contributor

The C++ stdlib overlay binaries (libswiftCxx and libswiftCxxStdlib) are now a part of the toolchain, not the OS SDKs. This makes sure that these binaries are built when building the toolchain separately from the stdlib.

rdar://105799283

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Feb 23, 2023
@egorzhdan egorzhdan requested review from hyp and zoecarver February 23, 2023 17:25
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

@swift-ci please test

The C++ stdlib overlay binaries (`libswiftCxx` and `libswiftCxxStdlib`) are now a part of the toolchain, not the OS SDKs. This makes sure that `libswiftCxx` is built when building the toolchain separately from the stdlib.

rdar://105799283
@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-toolchain-build branch from 9960c6c to 1d5de34 Compare February 25, 2023 00:24
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@egorzhdan egorzhdan merged commit 8102b63 into main Feb 27, 2023
@egorzhdan egorzhdan deleted the egorzhdan/cxx-toolchain-build branch February 27, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant