stdlib: remove VS injection for Swift development #63880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @kubamracek @gottesmm There is some amount of dependency here on #63879, so keeping this as a draft, but this is largely ready I think. |
|
@swift-ci please test Windows platform |
compnerd
force-pushed
the
development-vfs
branch
from
e062f52 to
ebf3f62
Compare
|
@swift-ci please test Windows platform |
|
@swift-ci please test |
compnerd
force-pushed
the
development-vfs
branch
from
08e072c to
0a791dc
Compare
compnerd
requested review from
shahmishal,
zoecarver,
hyp,
egorzhdan,
hborla,
xedin,
slavapestov and
eeckstein
as code owners
compnerd
force-pushed
the
development-vfs
branch
from
0a791dc to
7d62b14
Compare
|
@swift-ci please test |
compnerd
force-pushed
the
development-vfs
branch
from
7d62b14 to
1e6458a
Compare
|
@swift-ci please test |
compnerd
force-pushed
the
development-vfs
branch
from
1e6458a to
45f80ec
Compare
|
@swift-ci please test |
compnerd
force-pushed
the
development-vfs
branch
from
45f80ec to
4e80ead
Compare
|
@swift-ci please test Windows platform |
compnerd
force-pushed
the
development-vfs
branch
from
4e80ead to
0e34276
Compare
|
@swift-ci please test Windows platform |
compnerd
force-pushed
the
development-vfs
branch
from
0e34276 to
9a8f354
Compare
|
@swift-ci please test |
compnerd
force-pushed
the
development-vfs
branch
from
9a8f354 to
ada846b
Compare
|
@swift-ci please test |
compnerd
force-pushed
the
development-vfs
branch
from
ada846b to
e3e2d1d
Compare
|
@swift-ci please test |
Inject the necessary module maps and apinotes via the VFS. This cleans up the developer build in preparation for a secondary change to remove this need for deployed scenarios as well. Injecting the content via the VFS will enable us restore the ability to work with a pristine installation of Visual Studio, dropping the custom action for the Swift installer, and open the pathway to per-user installation of Swift. Thanks to @bnbarham for the help and discussion in resolving the test issues.
compnerd
force-pushed
the
development-vfs
branch
from
e3e2d1d to
4075d70
Compare
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject the necessary module maps and apinotes via the VFS. This cleans
up the developer build in preparation for a secondary change to remove
this need for deployed scenarios as well. Injecting the content via the
VFS will enable us restore the ability to work with a pristine
installation of Visual Studio, dropping the custom action for the Swift
installer, and open the pathway to per-user installation of Swift.
Thanks to @bnbarham for the help and discussion in resolving the test
issues.