[5.8][ClangImporter] Fix stack-use-after-scope in createClangInvocation #63882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClangDiagnosticConsumer was initialized on the stack in a scope of 'if' branch, and was passed to the DiagnosticEngine as a pointer. Then the diagnostic engine was used outside the scope. Instead, allocate the consumer in the heap, and pass to the engine with `ShouldOwnClient` true. So the engine takes the ownership. Speculative fix for rdar://105801504 (cherry picked from commit 1f3d671)
|
@swift-ci Please test |
|
https://ci.swift.org/job/swift-PR-Linux/6225/console unrelated failure |
|
@swift-ci Please test Linux |
nkcsgexi
approved these changes
Feb 24, 2023
artemcm
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Cherry-pick #63881 into
release/5.8)stack-use-after-scopein ClangImporter'screateClangInvocation()function. When creating temporary diagnostic engine for creating invocation object, the consumer object is created insideif...elsebranches on the stack, but the pointer to it was used outside the scope. That can cause random unpredictable crashes, for example, if the clang compiler argument was malformed. This change resolves that by instantiating the diagnostic consumer on heap, then let the diagnostic engine take the ownership.