IRGen: Reuse "POD" to mean "trivially destroyable", and add a "Copyable" bit. #63896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
Noncopyable types aren't really "POD", but the bit is still useful to track whether a noncopyable type has a no-op destroy operation, so rename the existing bit to be more specific within IRGen's implementation. Don't rename it in the runtime or Builtin names yet, since doing so will require a naming transition for compatibility.
And use the new bit to ensure we don't try to lower move-only types with common layout value witness surrogates. Take a bit in the runtime value witness flags to represent types that are not copyable.
jckarter
force-pushed
the
moveonly-value-witness-bits
branch
from
1314347 to
f8e3e40
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.