Sema: Allow unavailable protocol witnesses in unavailable nominals or extensions #63898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
AnthonyLatsis,
hborla and
slavapestov
as code owners
tshortli
force-pushed
the
allow-unavailable-witness-on-unavailable-type
branch
from
e017532 to
94d1f38
Compare
… extensions. Resolves rdar://99451416
tshortli
force-pushed
the
allow-unavailable-witness-on-unavailable-type
branch
from
94d1f38 to
9521764
Compare
|
@swift-ci please test |
nkcsgexi
approved these changes
Feb 28, 2023
artemcm
approved these changes
Feb 28, 2023
|
@swift-ci please test macOS |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 22, 2023
…ances. In swiftlang#63898 conformance requirement typechecking was relaxed to allow unavailable decls to witness conformance requirements as long as the conforming nominal was also unavailable. However, only nominals that were directly marked unavailable were accepted. Nominals that are declared in unavailable scopes should also be allowed to have unavailable wintesses. Resolves rdar://107052715
etcwilde
pushed a commit
to etcwilde/swift
that referenced
this pull request
Apr 19, 2023
…ances. In swiftlang#63898 conformance requirement typechecking was relaxed to allow unavailable decls to witness conformance requirements as long as the conforming nominal was also unavailable. However, only nominals that were directly marked unavailable were accepted. Nominals that are declared in unavailable scopes should also be allowed to have unavailable wintesses. Resolves rdar://107052715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://99451416