Skip to content

[Reflection] Implement an SPI to iterate types who conform to some protocol #63955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Reflection] Implement an SPI to iterate types who conform to some protocol #63955

wants to merge 2 commits into from

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Feb 28, 2023

Resolves: rdar://105290756

@Azoy Azoy requested a review from mikeash February 28, 2023 01:07
@Azoy
Copy link
Contributor Author

Azoy commented Feb 28, 2023

@swift-ci please smoke test

mikeash
mikeash approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@mikeash mikeash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. /cc @grynspan

@Azoy
Copy link
Contributor Author

Azoy commented Feb 28, 2023

@swift-ci please smoke test

@grynspan
Copy link
Contributor

This PR includes a lot of code duplicated from the main runtime sources. I don't think that's the right approach here. Surely we can just bubble something up from the runtime's module directly?

@Azoy Azoy force-pushed the conformance-spi branch from 9264b4a to 7e671dd Compare March 1, 2023 18:05
@Azoy
Copy link
Contributor Author

Azoy commented Mar 1, 2023

@mikeash @grynspan I've moved some of the common definitions from the runtime into the include header so the reflection module can easily use it. Let me know what you think.

@mikeash mikeash mentioned this pull request Mar 1, 2023
Merged
@grynspan
Copy link
Contributor

grynspan commented Mar 1, 2023

Why can't you just include the headers at their old locations?

@Azoy Azoy closed this Mar 20, 2023
@Azoy Azoy deleted the conformance-spi branch March 20, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeash mikeash mikeash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Azoy @grynspan @mikeash