[Backtracing] Add support for looking up paths for auxiliary executables #63964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to duplicate the original PR from al45tair#8, which was reviewed by @mikeash and @grynspan, as I couldn't get that PR to point at apple:main. |
…les. We need to be able to locate `swift-backtrace` relative to the current location of the runtime library. This needs to work: * In a Swift build directory. * On Darwin, where we're installed in /usr/lib/swift and /usr/libexec/swift. * On Linux, where we're in /usr/lib/swift/linux and /usr/libexec/swift/linux. * On Windows, where we may be in a flat directory layout (because of limitations of Windows DLL lookups). rdar://103071801
This should have said how to release the string. rdar://103071801
Renamed a couple of functions following review feedback. Also added some extra words to the comments. rdar://103071801
We need to cast in order to call `free()`. rdar://103071801
al45tair
force-pushed
the
backtracing/path-lookup
branch
from
8f6cb44 to
35a2f17
Compare
This must have ended up in the wrong PR in the stack. It is needed in this one so that we can locate libswiftCore. rdar://103071801
Since it's copying, it may as well return `char *` instead of `const char *`. rdar://103071801
…nge. rdar://103071801
rdar://103071801
|
@swift-ci Please test |
|
@swift-ci Please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to locate swift-backtrace relative to the current location of the runtime library.
This needs to work:
In a Swift build directory.
On Darwin, where we're installed in /usr/lib/swift and /usr/libexec/swift.
On Linux, where we're in /usr/lib/swift/linux and /usr/libexec/swift/linux.
On Windows, where we may be in a flat directory layout (because of limitations of Windows DLL lookups).
rdar://103071801