Add Swift compilation flags to enable Clang's validate-per-build-session module behavior #63975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion module behavior Add '-validate-clang-modules-once' and '-clang-build-session-file' corresponding to Clang's '-fmodules-validate-once-per-build-session' and '-fbuild-session-file='. Ensure they are propagated to module interface build sub-invocations. We require these to be first-class Swift options in order to ensure they are propagated to both: ClangImporter and implicit interface build compiler sub-invocations. Compiler portion of rdar://105982120
artemcm
requested review from
zoecarver,
hyp,
egorzhdan,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci test |
tshortli
reviewed
Feb 28, 2023
Co-authored-by: Allan Shortlidge <[email protected]>
tshortli
approved these changes
Feb 28, 2023
|
@swift-ci test |
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Feb 28, 2023
…ion module behavior Compiler flags added in: swiftlang/swift#63975 Driver portion of rdar://105982120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-validate-clang-modules-onceand-clang-build-session-filecorresponding to Clang's-fmodules-validate-once-per-build-sessionand-fbuild-session-file=. Ensure they are propagated to module interface build sub-invocations.We require these to be first-class Swift options in order to ensure they are propagated to both: ClangImporter and implicit interface build compiler sub-invocations.
Compiler portion of rdar://105982120 (Driver: swiftlang/swift-driver#1302)