[Backtracing] Add support for building target executables into libexec. #63978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to add a program, `swift-backtrace`, that gets built alongside the stdlib and the runtime, and that needs to be installed in libexec/swift alongside the libraries in lib/swift. It wants to be built with the stdlib/runtime because there's an internal interface between `swift-backtrace` and the runtime, so the program needs to stay in lock-step with the runtime library. rdar://105390807 (This reverts commit f042ca0.)
… targets.
I missed off an `${sdk}` in the target name for the lipo'd output :-(
rdar://105390807
`THIN_INPUT_TARGETS` needed to be reset per-sdk, not just once. rdar://105390807
|
@swift-ci Please test |
|
The original attempt at this was #63650. Unfortunately there were a couple of bugs that caused the build to fail if we were building for more than one SDK at once, so that one got reverted. |
MaxDesiatov
reviewed
Mar 1, 2023
MaxDesiatov
reviewed
Mar 1, 2023
MaxDesiatov
approved these changes
Mar 1, 2023
|
I think that this inadvertently is impacting the Windows builds: |
|
That should be fixed by #64010. Hopefully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to add a program,
swift-backtrace, that gets built alongside the stdlib and the runtime, and that needs to be installed in libexec/swift alongside the libraries in lib/swift.It wants to be built with the stdlib/runtime because there's an internal interface between
swift-backtraceand the runtime, so the program needs to stay in lock-step with the runtime library.rdar://105390807