Skip to content

[Reflection] Fix build breakage caused by wrong type argument. #64029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2023
Merged

[Reflection] Fix build breakage caused by wrong type argument. #64029

merged 1 commit into from
Mar 2, 2023

Conversation

al45tair
Copy link
Contributor

@al45tair al45tair commented Mar 2, 2023

The discriminator argument to int_ptrauth_sign needs to be an Builtin.Int64, not a UInt64.

rdar://106138642

@al45tair
Copy link
Contributor Author

al45tair commented Mar 2, 2023

@swift-ci Please test macOS platform

@al45tair
Copy link
Contributor Author

al45tair commented Mar 2, 2023

@swift-ci Please smoke test Linux platform

@al45tair
Copy link
Contributor Author

al45tair commented Mar 2, 2023

Fixes a problem introduced in #63999

@al45tair al45tair requested review from mikeash and Azoy March 2, 2023 12:39
@Azoy
Copy link
Contributor

Azoy commented Mar 2, 2023

I believe the ._value goes after initializing the UInt64. What does the built in discriminator function return? Can we just skip the UInt64 initializer entirely? Thanks for doing this!

@al45tair
Copy link
Contributor Author

al45tair commented Mar 2, 2023

I believe the ._value goes after initializing the UInt64. What does the built in discriminator function return? Can we just skip the UInt64 initializer entirely? Thanks for doing this!

Yes, you're right, I got it inside the paren when it should have been outside.

@al45tair
[Reflection] Fix build breakage caused by wrong type argument.
6869579 
The discriminator argument to int_ptrauth_sign needs to be a Builtin.Int64,
not a UInt64.  We should probably just not have the `UInt64()`.

rdar://106138642
@al45tair
Copy link
Contributor Author

al45tair commented Mar 2, 2023

What does the built in discriminator function return? Can we just skip the UInt64 initializer entirely?

Judging by the error messages, I think we can, yes. Let's try that instead.

@al45tair
Copy link
Contributor Author

al45tair commented Mar 2, 2023

@swift-ci Please test macOS platform

@al45tair
Copy link
Contributor Author

al45tair commented Mar 2, 2023

@swift-ci Please smoke test Linux platform

@etcwilde etcwilde mentioned this pull request Mar 2, 2023
Merged
@tshortli tshortli mentioned this pull request Mar 2, 2023
Merged
@shahmishal shahmishal merged commit 0bb5425 into swiftlang:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeash mikeash mikeash approved these changes

@Azoy Azoy Awaiting requested review from Azoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@al45tair @Azoy @mikeash @shahmishal