[NFC] Create PackageUnit class, and Package entries to DeclContext / ASTHierarchy
#64034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
elsh
changed the title
package scope / add corresponding entries to DeclContext and ASTHierarchyPackageUnit class, and Package entries to DeclContext / ASTHierarchy
|
@swift-ci test |
elsh
changed the title
PackageUnit class, and Package entries to DeclContext / ASTHierarchyPackageUnit class, and Package entries to DeclContext / ASTHierarchy
|
@swift-ci test |
…THierarchy Previously enum AccessLimitKind was added to distinguish access scopes b/t package and public while keeping DeclContext null but it proved to be too limiting. This PR creates package specific entries for DeclContext and ASTHierarchy. It create a new class PackageUnit that can be set as the parent DeclContext of ModuleDecl. This PR contains addition of such entries but not the use of them; the actual use of them will be in the upcoming PRs. Resolves rdar://106155600
|
@swift-ci test |
|
@swift-ci test |
xymus
reviewed
Mar 2, 2023
| @@ -1830,7 +1831,6 @@ static bool shouldSerializeMember(Decl *D) { | |||
| if (D->getASTContext().LangOpts.AllowModuleWithCompilerErrors) | |||
| return false; | |||
| llvm_unreachable("decl should never be a member"); | |||
|
|
|||
| case DeclKind::Missing: | |||
There was a problem hiding this comment.
Nitpick: This chunk and the next one doesn't fit with the overall spacing style of this code. If you get back to this code or have to update this PR it would be nice to make it uniform.
xymus
approved these changes
Mar 2, 2023
|
@swift-ci smoke test |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
enum AccessLimitKindwas added to distinguish access scopes b/tpackageandpublicwhile keepingDeclContextnull but it proved to be too limiting. This PR createspackagespecific entries for DeclContext and ASTHierarchy. It create a new classPackageUnitthat can be set as the parent DeclContext ofModuleDecl. This PR contains addition of such entries but not the use of them; the actual use of them will be in the upcoming PRs.Resolves rdar://106155600