Skip to content

[CSSimplify] Detect and diagnose generic argument mismatches individually #64036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Mar 2, 2023

Generic arguments types are not always resolved enough to enable
aggregated mismatch fixes, which means that the solver should be
able to handle standalone generic argument matching constraints
and create a fix per mismatch location to coalesce them during
diagnostics.

Resolves: rdar://106054263

@xedin xedin requested review from hborla and slavapestov as code owners March 2, 2023 19:03
@xedin
Copy link
Contributor Author

xedin commented Mar 2, 2023

@swift-ci please test

This locator is going to be used as a "parent" element for
"generic argument" elements.
@xedin
Copy link
Contributor Author

xedin commented Mar 4, 2023

@swift-ci please test

xedin added 2 commits March 4, 2023 21:57
…ally

Generic arguments types are not always resolved enough to enable
aggregated mismatch fixes, which means that the solver should be
able to handle standalone generic argument matching constraints
and create a fix per mismatch location to coalesce them during
diagnostics.

Resolves: rdar://106054263
@xedin
Copy link
Contributor Author

xedin commented Mar 5, 2023

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Mar 5, 2023

@swift-ci please test Linux platform

@xedin
Copy link
Contributor Author

xedin commented Mar 6, 2023

@swift-ci please test Linux platform

@xedin xedin merged commit 342e5f6 into swiftlang:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants