Skip to content

[Variadic Generics] type parameter pack syntax change: T... -> each T #64039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2023
Merged

[Variadic Generics] type parameter pack syntax change: T... -> each T #64039

merged 1 commit into from
Mar 3, 2023

Conversation

sophiapoirier
Copy link
Contributor

No description provided.

@sophiapoirier sophiapoirier mentioned this pull request Mar 2, 2023
Merged
@sophiapoirier
Copy link
Contributor Author

btw I intend to add more tests cases for the ... diagnostic and fixits, however since this PR needs to merge this week, I may do that separately.

@sophiapoirier sophiapoirier force-pushed the pack-type-syntax-each branch from e47fad1 to 70cffb0 Compare March 2, 2023 22:42
@sophiapoirier
Copy link
Contributor Author

swiftlang/swift-syntax#1384

@swift-ci please smoke test

@sophiapoirier
Copy link
Contributor Author

I just rebased to latest main to absorb and fix one more recent addition of a T... syntax test.

@sophiapoirier
Copy link
Contributor Author

swiftlang/swift-syntax#1384

@swift-ci please smoke test Linux

hborla
hborla approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sophiapoirier sophiapoirier merged commit a9e5075 into swiftlang:main Mar 3, 2023
@sophiapoirier sophiapoirier mentioned this pull request Mar 4, 2023
Merged
@sophiapoirier sophiapoirier deleted the pack-type-syntax-each branch July 20, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@ahoppen ahoppen Awaiting requested review from ahoppen

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

@zoecarver zoecarver Awaiting requested review from zoecarver

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophiapoirier @hborla