Fix PrunedLiveness.empty() to consider the users. #64051
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrick
force-pushed
the
fix-liveness-empty
branch
from
20bc512 to
ae59e6b
Compare
nate-chandler
approved these changes
Mar 3, 2023
atrick
force-pushed
the
fix-liveness-empty
branch
from
ae59e6b to
2c12060
Compare
|
@swift-ci test |
|
Fixed in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit the issue with PrunedLiveness.empty() several months ago during development on a branch, but never had a test case. The comment explains why this is the obviously correct implementation though, so better to just fix it.