Small Sema fixes #6406
Merged
Small Sema fixes #6406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resolved associated types When building a generic signature, we would drop requirements where the LHS or RHS was a DependentMemberType with an unresolved associated type, however we didn't perform the same check for DependentMemberTypes that are nested inside structural types.
…etypes from context This could lead to verifier failures on invalid nesting of generic types in generic functions.
|
@swift-ci Please smoke test |
slavapestov
commented
Dec 20, 2016
| @@ -79,3 +79,13 @@ func takesAny(_ a: Any) {} | |||
| func badDiagnostic3() { | |||
| takesAny(Deli.self) // expected-error {{argument type 'Deli<_>.Type' does not conform to expected type 'Any'}} | |||
| } | |||
|
|
|||
| // Crash with missing nested type inside concrete type | |||
| class OuterGeneric<T> { | |||
There was a problem hiding this comment.
@DougGregor do we have any radars for this one? :)
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
DougGregor
reviewed
Jan 5, 2017
| auto result = substitutions.insert( | ||
| {gp->getCanonicalType()->castTo<GenericTypeParamType>(), | ||
| outerEnv->mapTypeIntoContext(gp)}); | ||
| genericEnv->mapTypeIntoContext(gp)}); |
| @@ -79,3 +79,13 @@ func takesAny(_ a: Any) {} | |||
| func badDiagnostic3() { | |||
| takesAny(Deli.self) // expected-error {{argument type 'Deli<_>.Type' does not conform to expected type 'Any'}} | |||
| } | |||
|
|
|||
| // Crash with missing nested type inside concrete type | |||
| class OuterGeneric<T> { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.