[Test] Fix swift_swift_parser feature and use in tests #64089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
bnbarham
force-pushed
the
add-swift-swift-parser-feature
branch
2 times, most recently
from
b268a81 to
e23abf0
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
add-swift-swift-parser-feature
branch
from
e23abf0 to
5733fe7
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
add-swift-swift-parser-feature
branch
from
5733fe7 to
f096297
Compare
bnbarham
changed the title
bnbarham
force-pushed
the
add-swift-swift-parser-feature
branch
from
f096297 to
0f2784e
Compare
|
@swift-ci please test |
rintaro
approved these changes
Mar 31, 2023
bnbarham
force-pushed
the
add-swift-swift-parser-feature
branch
from
0f2784e to
3292616
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
add-swift-swift-parser-feature
branch
from
3292616 to
c0642a5
Compare
|
@swift-ci please test |
The macro tests were all using "REQUIRES: OS=macosx" as a proxy for "have the Swift Swift parser". There was an existing feature for this, but it was just checking whether the path was passed through. Fix that to use the same variable as in CMake. Also remove all extraneous `-I` and `-L` to the host libs in the target invocations.
bnbarham
force-pushed
the
add-swift-swift-parser-feature
branch
from
c0642a5 to
e5a28ca
Compare
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro tests were all using "REQUIRES: OS=macosx" as a proxy for
"have the Swift Swift parser". There was an existing feature for this,
but it was just checking whether the path was passed through. Fix that
to use the same variable as in CMake.
Also remove all extraneous
-Iand-Lto the host libs in the targetinvocations.