Skip to content

[Backtracing] Mark withCurrentContext() as @_transparent. #64170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

al45tair
Copy link
Contributor

@al45tair al45tair commented Mar 7, 2023

The withCurrentContext() methods on the Context structs need to be inlined, even in debug builds, otherwise we would need to skip an extra frame at the top of the backtrace.

This fixes test failures in debug stdlib builds.

rdar://106276227

@al45tair al45tair requested a review from mikeash March 7, 2023 11:44
@al45tair
Copy link
Contributor Author

al45tair commented Mar 7, 2023

@swift-ci Please smoke test

@al45tair al45tair requested a review from meg-gupta March 7, 2023 11:51
The `withCurrentContext()` methods on the `Context` structs need to be
inlined, even in debug builds, otherwise we would need to skip an extra
frame at the top of the backtrace.

This fixes test failures in debug stdlib builds.

rdar://106276227
@al45tair
Copy link
Contributor Author

al45tair commented Mar 7, 2023

@swift-ci Please smoke test

@al45tair al45tair merged commit d6cef2c into swiftlang:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants