[Serialization] Allow rebuilding modules from the resource dir on SDK mismatch #64181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behavior kept going even after we reported an invalid swiftmodule. As such it ended up losing the precise invalid reason and returned Malformed later on.
… mismatch Modules loaded from the resource dir are not usually rebuilt from the swiftinterface as it would indicate a configuration problem. Lift that behavior for SDK mismatch and still rebuild them. This use case applies when a toolchain is used with a different SDK than the one use to build the modules in the toolchain. rdar://106101760
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows |
|
@swift-ci Please smoke test macOS |
bnbarham
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules loaded from the resource dir are not usually rebuilt from the swiftinterface as it would indicate a configuration problem. Lift that behavior for SDK mismatch and still rebuild them.
This use case applies when a toolchain is used with a different SDK than the one use to build the modules in the toolchain.
rdar://106101760