Skip to content

Remove gyb from swift-syntax #64201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -74,23 +74,6 @@ def should_build(self, host_target):
return True

def build(self, host_target):
if self.args.swiftsyntax_verify_generated_files:
build_cmd = [
os.path.join(self.source_dir, 'build-script.py'),
'verify-source-code',
'--toolchain', self.install_toolchain_path(host_target),
# Verifying the files generated using SwiftSyntaxBuilder requires
# internet access to pull the pinned SwiftSyntaxBuilder version. Since
# we don't have internet access in CI, don't verify these files.
# This is not a huge deal because only SwiftSyntaxBuilder is generated
# in terms of itself and it will most likely fail to compile if it isn't
# re-generated after gyb files have been updated.
'--gyb-only'
]
if self.args.verbose_build:
build_cmd.append('--verbose')
shell.call(build_cmd)

self.run_swiftsyntax_build_script(target=host_target,
command='build')

Expand Down