Skip to content

SILCombine: handle convert_escape_to_noescape in the apply-of-convert-function optimization #64233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

eeckstein
Copy link
Contributor

This fixes a bad optimization deficiency for dictionary subscript lookups with default values: there shouldn't be a closure context allocated.

rdar://106423763

@eeckstein
Copy link
Contributor Author

@swift-ci test

@eeckstein
Copy link
Contributor Author

@swift-ci benchmark

fixes a crash when trying to optimize ABI incompatible function types
…rt-function optimization.

This fixes a bad optimization deficiency for dictionary subscript lookups with default values: there shouldn't be a closure context allocated.

rdar://106423763
@eeckstein eeckstein force-pushed the optimize-convert-function branch from 08b5f3c to 9deb942 Compare March 9, 2023 13:41
@eeckstein
Copy link
Contributor Author

@swift-ci test

@eeckstein
Copy link
Contributor Author

@swift-ci test macos

1 similar comment
@eeckstein
Copy link
Contributor Author

@swift-ci test macos

@eeckstein eeckstein merged commit 60378e1 into swiftlang:main Mar 13, 2023
@eeckstein eeckstein deleted the optimize-convert-function branch March 13, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant