Skip to content

[interop][SwiftToCxx] annotate several value type members as 'noexcept' #64307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Mar 12, 2023

This is needed to use generic types with some C++/clang versions as otherwise clang errors out on the lack of noexcept on the destructor.

hyp added 3 commits March 12, 2023 11:49
C++/clang is more strict about requiring noexcept in templates so we need some explicit annotations
@hyp hyp added the c++ interop Feature: Interoperability with C++ label Mar 12, 2023
@hyp hyp requested review from zoecarver and egorzhdan as code owners March 12, 2023 18:50
@hyp
Copy link
Contributor Author

hyp commented Mar 12, 2023

@swift-ci please test and merge

@hyp hyp changed the title [interop][SwiftToCxx] annotate several value members types as 'noexcept' [interop][SwiftToCxx] annotate several value type members as 'noexcept' Mar 12, 2023
@hyp
Copy link
Contributor Author

hyp commented Mar 13, 2023

@swift-ci please test and merge

@swift-ci swift-ci merged commit 6491dd5 into swiftlang:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants