[Clang importer] Restore historical definition of "Boolean for Objective-C" #64330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive-C" The `isBoolType` operation within the Clang importer has a historical definition that excludes the C++ `bool` and its use in C as an extension. Retain that definition, and check for the actual `bool` when importing C++ conversion functions into Swift. Fixes two regressions in the Clang importer: 1. We started to import `bool`-typed Objective-C properties with their getter names. 2. We started importing `bool`-typed Objective-C methods with an NSError** parameter as `throws`. Both of these changes could be considered improvements, but they cannot be made without breaking source compatibility, so roll those changes back to maintain source compatibility. We should have a separate discussion about enabling this behavior for Swift >= 6.
|
@swift-ci please smoke test and merge |
|
Oh I didn't realize the impact on Objective-C when I made the original change, thanks @DougGregor for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isBoolTypeoperation within the Clang importer has a historical definition that excludes the C++booland its use in C as an extension. Retain that definition, and check for the actualboolwhen importing C++ conversion functions into Swift.Fixes two regressions in the Clang importer:
bool-typed Objective-C properties with their getter names.bool-typed Objective-C methods with an NSError** parameter asthrows.Both of these changes could be considered improvements, but they cannot be made without breaking source compatibility, so roll those changes back to maintain source compatibility.
We should have a separate discussion about enabling this behavior for Swift >= 6.
Fixes rdar://106665264