Better enforce GenericFunctionType TypeVariableType invariant #64335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce that we don't have any type variables present in either the result or parameter types. To ensure the constraint system doesn't violate this invariant, refactor `getTypeOfMemberReference` slightly to avoid construction of a `GenericFunctionType` as a means of opening the generic parameters of the context for a VarDecl.
hamishknight
requested review from
hborla,
xedin and
slavapestov
as code owners
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
xedin
approved these changes
Mar 13, 2023
|
Source compat failures unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce that we don't have any type variables present in either the result or parameter types. To ensure the constraint system doesn't violate this invariant, refactor
getTypeOfMemberReferenceslightly to avoid construction of aGenericFunctionTypeas a means of opening the generic parameters of the context for a VarDecl.