Skip to content

[interop] ensure std::pair is imported into Swift #64348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2023
Merged

[interop] ensure std::pair is imported into Swift #64348

merged 1 commit into from
Mar 14, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Mar 14, 2023

Returning it by value from function causes IRGen crash which I'll fix in a followup.

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Mar 14, 2023
@hyp hyp requested review from zoecarver and egorzhdan as code owners March 14, 2023 14:30
@hyp
Copy link
Contributor Author

hyp commented Mar 14, 2023

@swift-ci please test

egorzhdan
egorzhdan approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think we might want to come up with a list of std types that are allowed to be instantiated many times (possibly without a limit?), other such types could be vector, map, set, etc.

@hyp
Copy link
Contributor Author

hyp commented Mar 14, 2023

@swift-ci please test windows platform

@hyp hyp merged commit c1134a7 into swiftlang:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorzhdan egorzhdan egorzhdan approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyp @egorzhdan