Gets rid of for-loop deprecation compiler warnings in stdlib/public/core #644
Conversation
kovpas
force-pushed
the
for_loop_warnings
branch
from
bf03c03 to
7fd0bcd
Compare
| @@ -367,8 +367,10 @@ Type TypeChecker::applyGenericArguments(Type type, | |||
| if (!unbound) { | |||
| // FIXME: Highlight generic arguments and introduce a Fix-It to remove | |||
| // them. | |||
| diagnose(loc, diag::not_a_generic_type, type); | |||
|
|
|||
| if (!type->is<ErrorType>()) { | |||
There was a problem hiding this comment.
This should be part of a separate pull request.
There was a problem hiding this comment.
These are not my changes. Probably rebase issues. Fixing.
kovpas
force-pushed
the
for_loop_warnings
branch
from
7fd0bcd to
6a63909
Compare
|
Can you separate out the generic-specialization-of-error-type changes? |
|
@DougGregor that was a rebase issue, I've already fixed this. |
kovpas
force-pushed
the
for_loop_warnings
branch
from
e81a49f to
16f4f4e
Compare
|
We had applied such a change before, and it caused performance issues. We can safely take all changes outside of @nadavrot, how would you like to proceed with this? @kovpas Feel free to split the patch into the |
kovpas
force-pushed
the
for_loop_warnings
branch
from
16f4f4e to
3946624
Compare
kovpas
changed the title
|
@gribozavr done: #653 |
|
I believe this is already implemented in master. |
[Stress tester XFails] Update XFails
Not too many warnings, but still rather annoying.