Skip to content

[cxx-interop] Do not auto-complete unsafe underscored methods, part 2 #64453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

egorzhdan
Copy link
Contributor

Previous patch removed unsafe C++ methods from the module interface, but not from auto-completion results.

rdar://103252957

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Mar 17, 2023
@egorzhdan egorzhdan requested review from zoecarver and hyp as code owners March 17, 2023 16:05
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

Previous patch removed unsafe C++ methods from the module interface, but not from auto-completion results.

rdar://103252957
@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-completion-unsafe branch from 3a3c415 to 9247d53 Compare March 17, 2023 18:04
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan merged commit 55a08bb into main Mar 17, 2023
@egorzhdan egorzhdan deleted the egorzhdan/cxx-completion-unsafe branch March 17, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants