[SourceKit] Update requests to handle locations within generated buffers #64456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
force-pushed
the
nested-cursor
branch
2 times, most recently
from
fea4607 to
941db55
Compare
|
@swift-ci please test |
ahoppen
reviewed
Mar 20, 2023
bnbarham
force-pushed
the
nested-cursor
branch
2 times, most recently
from
2347629 to
88d0023
Compare
|
@swift-ci please test |
|
@swift-ci please test |
Update requests to handle being passed a separate `key.primary_file` which specifies the file to use for building the AST. `key.sourcefile` is then the file to find in `SourceManager`, which could be a generated buffer. Resolves rdar://106863186.
|
@swift-ci please test |
ahoppen
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update requests to handle being passed a separate
key.primary_filewhich specifies the file to use for building the AST.key.sourcefileis then the file to find inSourceManager, which could be a generated buffer.Resolves rdar://106863186.