Do not load modules of the same package if built from interface #64488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsh
requested review from
artemcm,
hborla,
slavapestov and
xedin
as code owners
artemcm
reviewed
Mar 20, 2023
artemcm
approved these changes
Mar 20, 2023
xymus
reviewed
Mar 20, 2023
|
This seems to be too restrictive. Modules belong to the same package should load even with only textual interfaces, no? |
Interface modules should load if they are from a different package; will update accordingly. |
elsh
changed the title
|
@swift-ci smoke test |
|
@swift-ci clean smoke test |
|
@swift-ci clean smoke test |
xymus
reviewed
Mar 21, 2023
xymus
approved these changes
Mar 21, 2023
- Show diagnostics with an interface path Resolves rdar://104617990
|
@swift-ci smoke test |
elsh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://104617990