Skip to content

[CopyPropagation] Canonicalize moved-from values. #64495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nate-chandler
Copy link
Contributor

@nate-chandler nate-chandler commented Mar 21, 2023

If a move_value is determined to be redundant and removed, take the opportunity its removal makes available to canonicalize the moved-from value without the obstruction of the move_value.

rdar://106996304

If a move_value is determined to be redundant and removed, take the
opportunity its removal makes available to canonicalize the moved-from
value without the obstruction of the move_value.
@nate-chandler nate-chandler force-pushed the copy-propagation/canonicalize-move-source branch from 25be01c to 6b1bee7 Compare March 21, 2023 01:05
@nate-chandler
Copy link
Contributor Author

@swift-ci please benchmark

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test macOS platform

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test macos platform

@nate-chandler nate-chandler merged commit cee3890 into swiftlang:main Mar 21, 2023
@nate-chandler nate-chandler deleted the copy-propagation/canonicalize-move-source branch March 21, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants