add missing symbols to compatibility-symbols #64510
Conversation
rdar://104389344
QuietMisdreavus
requested review from
zoecarver,
hyp and
egorzhdan
as code owners
|
@swift-ci Please smoke test |
| @@ -0,0 +1,11 @@ | |||
| // RUN: %empty-directory(%t) | |||
| // RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) %S/../Inputs/empty.swift -typecheck -emit-objc-header-path %t/empty.h | |||
| // RUN: %clang -extract-api -o %t/empty.symbols.json --target=%target-triple -isysroot %clang-importer-sdk-path -F %clang-importer-sdk-path/frameworks --extract-api-ignores=%swift_obj_root/share/swift/compatibility-symbols -fmodules -x objective-c-header %t/empty.h | |||
There was a problem hiding this comment.
If I got that right you run clang extract-api on a compatibility header and check that nothing ends up in the output? I still think the compatibility header has a module name dependent macro in it?
There was a problem hiding this comment.
That's correct. The header guard macro is being filtered out here by clang's own filtering. It's not a problem here, but if we were to (e.g.) run extract-api on a header that was merged together by Xcode, it would be a problem there. The merging behavior disrupts Clang's header-guard detection, because there the first thing in the file isn't the header-guard declaration, but a processor arch check. I'm not sure the best way to handle that, especially since all we are able to provide to Clang is a static file that we install in the toolchain.
|
@swift-ci Please test |
Resolves rdar://104389344
ClangMacros.defwas missing three symbols in comparison to the macros and typedefs parsed by clang extract-api. This PR adds these missing symbols, as well as a test that usesclang -extract-apion a generated header to ensure that compatibility-symbols is kept up-to-date moving forward.