Skip to content

[interop][sourcekit] print submodules of CxxStdlib when printing out … #64523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2023
Merged

[interop][sourcekit] print submodules of CxxStdlib when printing out … #64523

merged 1 commit into from
Mar 25, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Mar 22, 2023

…IDE interface of it

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Mar 22, 2023
@hyp hyp requested review from egorzhdan and zoecarver March 22, 2023 00:16
@hyp
Copy link
Contributor Author

hyp commented Mar 22, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Mar 22, 2023

@swift-ci please build toolchain

@hyp hyp force-pushed the eng/libcxx-module-int branch from 90f09e0 to 329b175 Compare March 22, 2023 02:15
@hyp
Copy link
Contributor Author

hyp commented Mar 22, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Mar 22, 2023

@swift-ci please build toolchain

egorzhdan
egorzhdan reviewed Mar 22, 2023
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this?

@hyp
Copy link
Contributor Author

hyp commented Mar 22, 2023

@egorzhdan to print out the module interface for libc++ fully in an IDE that uses sourcekit.

@hyp
Copy link
Contributor Author

hyp commented Mar 22, 2023

@swift-ci please test macos

@hyp
Copy link
Contributor Author

hyp commented Mar 22, 2023

unfortunately it might not be enough :(

@egorzhdan
Copy link
Contributor

to print out the module interface for libc++ fully in an IDE that uses sourcekit.

The module interface currently starts with imports statements for each of the submodules, and the user should be able to view the interface for a submodule by clicking on the import statement, e.g.

import CxxStdlib.<click>iosfwd

It works this way for other system modules such as Darwin, Foundation, etc.

Do you think there is a reason to make CxxStdlib an exception?

@hyp
Copy link
Contributor Author

hyp commented Mar 23, 2023

maybe, I need to get it working first.

@hyp hyp force-pushed the eng/libcxx-module-int branch from 329b175 to 772909e Compare March 24, 2023 16:31
@hyp
Copy link
Contributor Author

hyp commented Mar 24, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Mar 24, 2023

@swift-ci please build toolchain

1 similar comment
@hyp
Copy link
Contributor Author

hyp commented Mar 24, 2023

@swift-ci please build toolchain

@hyp hyp merged commit 4e14288 into swiftlang:main Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorzhdan egorzhdan egorzhdan left review comments

@zoecarver zoecarver Awaiting requested review from zoecarver

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyp @egorzhdan