[CSSimplify] Don't propagate contextual parameter type if it's a pack… #64531
Conversation
| // Cannot propagate pack expansion type from context, | ||
| // it has to be handled by type matching logic. | ||
| if (contextualTy->is<PackExpansionType>()) | ||
| return false; |
There was a problem hiding this comment.
If I understand everything correctly we could allow that by using getPatternType but I think in vast majority of cases (if not all) it would result in a type variable anyway which is not a suitable type too.
There was a problem hiding this comment.
We would need to wait until the pattern type is fully substituted and flattened. The pattern type in this case will be substituted with PackType{String}, and the pack expansion will flatten the pack type into just String
There was a problem hiding this comment.
Right, I figured that it better to let it go through the matching logic than try to do anything fancy here.
… expansion Pack expansion types are handled by matching logic, optimization that attempts to propagate types into the body of the closure should consider them unsuitable even if the pack expansion matches a single parameter.
xedin
force-pushed
the
pack-expansion-and-closure-params
branch
from
d7ec5fe to
b4937be
Compare
|
@swift-ci please test |
|
@swift-ci please clean test macOS platform |
|
@swift-ci please test macOS platform |
… expansion
Pack expansion types are handled by matching logic, optimization that attempts
to propagate types into the body of the closure should consider them unsuitable
even if the pack expansion matches a single parameter.