Fix SILCombine of pointer_to_address instruction #64533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
nate-chandler
approved these changes
Mar 22, 2023
| // CHECK-LABEL: sil [ossa] @a2p_p2a_reinterpret_cast_word_raw_pointer2 | ||
| // CHECK: unchecked_addr_cast | ||
| // CHECK: } // end sil function 'a2p_p2a_reinterpret_cast_word_raw_pointer2' | ||
| sil [ossa] @a2p_p2a_reinterpret_cast_word_raw_pointer2 : $@convention(thin) (@owned ContiguousArray<UInt16>) -> () { |
There was a problem hiding this comment.
Does this test currently fail? Running sil-opt -sil-combine on this function with a not too old main (70b982f), valid code seems to be generated even when specifying -sil-opt-pass-count=1.6 to stop after adding the unchecked_addr_cast.
There was a problem hiding this comment.
Thanks! I had minimized the test too much.. Modified to a test that will fail without the patch now.
This change ensures the insertion point of the unchecked_addr_cast is after any copies/borrows that OSSA rauw may create. Before this fix we could end up creating invalid SIL where operands do not dominate its instruction.
meg-gupta
force-pushed
the
fixsilcombineptai
branch
from
c028fcc to
3812dad
Compare
|
@swift-ci smoke test and merge |
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Mar 22, 2023
This change ensures the insertion point is after any copies/borrows that OSSA rauw may create. Before this fix we could end up creating invalid SIL where operands do not dominate its instruction. Similar to swiftlang#64533. Found by inspection.
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Mar 22, 2023
This change ensures the insertion point is after any copies/borrows that OSSA rauw may create. Before this fix we could end up creating invalid SIL where operands do not dominate its instruction. Similar to swiftlang#64533. Found by inspection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures the insertion point of the unchecked_addr_cast is after any copies/borrows that OSSA rauw may create.
Before this fix we could end up creating invalid SIL where operands do not dominate its instruction.