[stdlib] Collection types are eagerMove. #64553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
eagermove_collections
branch
from
8167686 to
d195ef0
Compare
|
@swift-ci please test |
|
@swift-ci please benchmark |
nate-chandler
force-pushed
the
eagermove_collections
branch
from
d195ef0 to
38d20c7
Compare
|
@swift-ci please test |
atrick
approved these changes
Mar 23, 2023
nate-chandler
force-pushed
the
eagermove_collections
branch
from
38d20c7 to
cd58ebb
Compare
|
@swift-ci please test |
nate-chandler
force-pushed
the
eagermove_collections
branch
from
cd58ebb to
786efd6
Compare
|
@swift-ci please test |
nate-chandler
force-pushed
the
eagermove_collections
branch
2 times, most recently
from
2b00732 to
01cb9cd
Compare
|
@swift-ci please test |
Types that have "value semantics" should not have lexical lifetimes. Value types are not expected to have custom deinits. Are not expected to expose unsafe interior pointers. And cannot have weak references because they are structs. Therefore, deinitialization barriers are irrelevant. rdar://107076869
rdar://92652273
Use the new mechanism for looking into tuples that properly handles packs.
nate-chandler
force-pushed
the
eagermove_collections
branch
from
01cb9cd to
ff3ec19
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value types are not expected to have custom deinits, are not expected to expose unsafe interior pointers, and cannot have weak references. So, deinitialization barriers are irrelevant.
rdar://107076869