[SymbolGraphGen] allow SourceKit to print declarations for private stdlib symbols #64556
Conversation
Resolves rdar://103112656 Resolves #62457
QuietMisdreavus
requested review from
bnbarham,
ahoppen,
franklinsch and
daniel-grumberg
|
@swift-ci Please test |
| @@ -0,0 +1,9 @@ | |||
| // RUN: %sourcekitd-test -req=cursor -req-opts=retrieve_symbol_graph=1 -pos=8:13 %s -- %s | |||
There was a problem hiding this comment.
Would it be useful to check the response here as well?
Also, not required, but I find it easier to follow if the RUN line is right above the place where you invoke sourcekitd test and then uses -pos=%(line + 1):13. That also makes it easier to edit the file because adding new lines above the cursor info position doesn’t shift everything around.
There was a problem hiding this comment.
I thought about editing the test to give it a relative line number, but i also copied the test verbatim from the issue, so i didn't want to mess with it too much. 🤷♀️
It would be simple enough to check the response, but IMO the important thing here is that we don't crash.
|
@swift-ci Please test macOS |
| } | ||
|
|
||
| func test(lhs: AnyError) { | ||
| lhs.error._code |
There was a problem hiding this comment.
Could you add some checks that the symbol graph looks reasonable? Could name the test something like private-stdlib-symbol-graph.swift.
There was a problem hiding this comment.
Ah I see Alex beat me to that. I really do think the response is more relevant than the fact it crashed here.
There was a problem hiding this comment.
I've added some lines to test the declaration fragments, since that's what was crashing SymbolGraphGen.
|
@swift-ci Please test |
…dlib symbols (swiftlang#64556) Resolves rdar://103112656 Resolves swiftlang#62457
Resolves rdar://103112656
Resolves #62457
When SourceKit gets a cursor symbol graph for an internal stdlib symbol, the declaration fragment printer hits an assertion because it hasn't actually printed anything. This is because the PrintOptions used by the printer sets
SkipPrivateStdlibDeclsandSkipUnderscoredStdlibProtocols. This is useful when generating a whole-module symbol graph, but is causing problems for SourceKit. This PR adds an option to SymbolGraphOptions that turns those options off for SourceKit, so that these symbols can get a symbol graph correctly generated.