Fix linking libraries on Windows #6462
Conversation
hughbe
changed the title
| set(dep "${CMARK_LIBRARY_DIR}/${dep}.lib") | ||
| else() | ||
| set(dep "${CMARK_LIBRARY_DIR}/lib${dep}.a") | ||
| endif() |
There was a problem hiding this comment.
Hmm... Actually, aren't all of the ${SWIFTLIB_SINGLE_LINK_LIBRARIES} targets? We should use the OUTPUT_NAME from the target (or the LINK_LIBRARY) property to get the name to link against without having to worry about the target.
There was a problem hiding this comment.
Good idea, I've extracted this section of code to #6498. I haven't checked this recommendation out yet but I'll research
|
|
||
| # On Windows, we need to link mincore.lib for various file system APIs used by Clang. | ||
| if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows") | ||
| target_link_libraries("${name}" "mincore.lib") |
There was a problem hiding this comment.
Wouldn't clang have to link against those as well?
There was a problem hiding this comment.
Yeah, this is weird - very weird. I've done some research - only lib/AST and tools/SourceKit/lib/SwiftLang need mincore.lib. This is because they directly link to clangDriver.lib
|
I've updated the PR just to fix the _IMPLIB stuff - the other PRs should be rather self explantory |
|
@swift-ci Please smoke test |
_IMPLIBlibraries, to avoid the following errors:Extracted from #5904