Skip to content

Fix minimal stdlib builds with noncopyable types #64622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions include/swift/Basic/Features.def
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ EXPERIMENTAL_FEATURE(FreestandingMacros, true)
// but our tests currently rely on it, and we want to run those
// tests in non-asserts builds too.
EXPERIMENTAL_FEATURE(MoveOnlyClasses, true)
EXPERIMENTAL_FEATURE(NoImplicitCopy, true)
EXPERIMENTAL_FEATURE(OldOwnershipOperatorSpellings, true)

EXPERIMENTAL_FEATURE(OneWayClosureParameters, false)
EXPERIMENTAL_FEATURE(TypeWitnessSystemInference, false)
Expand Down
8 changes: 8 additions & 0 deletions lib/AST/ASTPrinter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3212,6 +3212,14 @@ static bool usesFeatureMoveOnlyClasses(Decl *decl) {
return isa<ClassDecl>(decl) && usesFeatureMoveOnly(decl);
}

static bool usesFeatureNoImplicitCopy(Decl *decl) {
return decl->isNoImplicitCopy();
}

static bool usesFeatureOldOwnershipOperatorSpellings(Decl *decl) {
return false;
}

static bool usesFeatureOneWayClosureParameters(Decl *decl) {
return false;
}
Expand Down
6 changes: 5 additions & 1 deletion lib/Frontend/CompilerInvocation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -721,8 +721,12 @@ static bool ParseLangArgs(LangOptions &Opts, ArgList &Args,
Opts.Features.insert(Feature::NamedOpaqueTypes);
if (Args.hasArg(OPT_enable_experimental_flow_sensitive_concurrent_captures))
Opts.Features.insert(Feature::FlowSensitiveConcurrencyCaptures);
if (Args.hasArg(OPT_enable_experimental_move_only))
if (Args.hasArg(OPT_enable_experimental_move_only)) {
// FIXME: drop addition of Feature::MoveOnly once its queries are gone.
Opts.Features.insert(Feature::MoveOnly);
Opts.Features.insert(Feature::NoImplicitCopy);
Opts.Features.insert(Feature::OldOwnershipOperatorSpellings);
}
if (Args.hasArg(OPT_experimental_one_way_closure_params))
Opts.Features.insert(Feature::OneWayClosureParameters);
if (Args.hasArg(OPT_enable_experimental_associated_type_inference))
Expand Down
2 changes: 1 addition & 1 deletion lib/Parse/ParseExpr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ ParserResult<Expr> Parser::parseExprSequenceElement(Diag<> message,
return sub;
}

if (Context.LangOpts.hasFeature(Feature::MoveOnly)) {
if (Context.LangOpts.hasFeature(Feature::OldOwnershipOperatorSpellings)) {
if (Tok.isContextualKeyword("_move")) {
Tok.setKind(tok::contextual_keyword);
SourceLoc awaitLoc = consumeToken();
Expand Down
2 changes: 1 addition & 1 deletion lib/Sema/TypeCheckAttr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ class AttributeChecker : public AttributeVisitor<AttributeChecker> {
void AttributeChecker::visitNoImplicitCopyAttr(NoImplicitCopyAttr *attr) {
// Only allow for this attribute to be used when experimental move only is
// enabled.
if (!D->getASTContext().LangOpts.hasFeature(Feature::MoveOnly)) {
if (!D->getASTContext().LangOpts.hasFeature(Feature::NoImplicitCopy)) {
auto error =
diag::experimental_moveonly_feature_can_only_be_used_when_enabled;
diagnoseAndRemoveAttr(attr, error);
Expand Down
1 change: 1 addition & 0 deletions stdlib/public/Concurrency/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ add_swift_target_library(swift_Concurrency ${SWIFT_STDLIB_LIBRARY_BUILD_TYPES} I
${SWIFT_STANDARD_LIBRARY_SWIFT_FLAGS}
-parse-stdlib
-Xfrontend -enable-experimental-concurrency
-enable-experimental-feature MoveOnly
-diagnostic-style swift
${SWIFT_RUNTIME_CONCURRENCY_SWIFT_FLAGS}
${swift_concurrency_options}
Expand Down
2 changes: 1 addition & 1 deletion test/stdlib/move_function.swift
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// RUN: %target-run-stdlib-swift(-O)
// RUN: %target-run-stdlib-swift(-O -enable-experimental-feature MoveOnly)

// REQUIRES: executable_test

Expand Down
7 changes: 6 additions & 1 deletion tools/sil-opt/SILOpt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -581,8 +581,13 @@ int main(int argc, char **argv) {
EnableExperimentalConcurrency;
Optional<bool> enableExperimentalMoveOnly =
toOptionalBool(EnableExperimentalMoveOnly);
if (enableExperimentalMoveOnly && *enableExperimentalMoveOnly)
if (enableExperimentalMoveOnly && *enableExperimentalMoveOnly) {
// FIXME: drop addition of Feature::MoveOnly once its queries are gone.
Invocation.getLangOptions().Features.insert(Feature::MoveOnly);
Invocation.getLangOptions().Features.insert(Feature::NoImplicitCopy);
Invocation.getLangOptions().Features.insert(
Feature::OldOwnershipOperatorSpellings);
}
for (auto &featureName : ExperimentalFeatures) {
if (auto feature = getExperimentalFeature(featureName)) {
Invocation.getLangOptions().Features.insert(*feature);
Expand Down