[SourceKit] Refactor collection of available refactorings #64663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
commented
Mar 28, 2023
| } | ||
| llvm::for_each(collectAvailableRefactoringsOtherThanRename(Info), | ||
| AddAction); | ||
| addRefactorings(Data.AvailableActions, collectRefactorings(Info, /*ExcludeRename=*/false)); |
There was a problem hiding this comment.
This came about because I added a check in to not retrieve refactorings when within a generated buffer. But one of these call paths skipped that check because it was using a different collect function. I've considered merging these before, so just went ahead and did it now.
There's now collectRefactorings in Refactoring.cpp and then an addRefactorings within SwiftSourceDocInfo.cpp which converts it to the LangSupport struct.
bnbarham
force-pushed
the
refactor-refactoring-collection
branch
from
8f6b7b8 to
737fbc5
Compare
|
@swift-ci please test |
rintaro
reviewed
Mar 28, 2023
Update to have a single refactoring collection method for cursor refactorings and another for ranges. The various functions were only needed because of the extra availability information on renames, so just give that to all refactorings.
bnbarham
force-pushed
the
refactor-refactoring-collection
branch
from
737fbc5 to
a1c8280
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to have a single refactoring collection method for cursor refactorings and another for ranges. The various functions were only needed because of the extra availability information on renames, so just give that to all refactorings.