🍒[5.9][Concurrency] SerialExecutor.isSameExclusiveExecutionContext #64665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
added
the
concurrency
ktoso
changed the title
|
@swift-ci please test |
|
@swift-ci please test linux |
|
@swift-ci please test macOS |
DougGregor
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This adds the ability for different SerialExecutor instances opt into "complex equality" which they can implement themselfes. This logic is opted in by returning the executor as an
UnownedSerialExecutor(complexEquality: self), and then the Swift runtime may choose to call theisSameExclusiveExecutionContexton the executor allowing it to implement "those two executors are using the same thread/queue and therefore should be considered the same exclusive context".Risk: Low, the API is feature guarded and additive with a default implementation.
Review by: @jckarter @rokhinip @rjmccall
Testing: CI testing; tests were added for this specific pattern.
Original PR: #64604
Radar: rdar://107174704