Skip to content

[ConstraintSystem] openOpaqueType: remove logic that duplicates bindArchetypesFromContext #64676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Mar 28, 2023

openGenericParameters calls bindArchetypesFromContext which would bind all of the
external generic parameters in the opaque type signature.

Resolves: rdar://107280056

@xedin xedin requested a review from slavapestov March 28, 2023 17:21
@xedin xedin requested a review from hborla as a code owner March 28, 2023 17:21
@xedin
Copy link
Contributor Author

xedin commented Mar 28, 2023

@swift-ci please test

Copy link
Contributor

@slavapestov slavapestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

xedin added 2 commits March 28, 2023 13:14
…ndArchetypesFromContext`

`openGenericParameters` calls `bindArchetypesFromContext` which would bind all of the
external generic parameters in the opaque type signature.

Resolves: rdar://107280056
… type

This aligns `bindArchetypesFromContext` with `getIdentitySubsitutionMap`
and other methods.
@xedin
Copy link
Contributor Author

xedin commented Mar 28, 2023

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Mar 28, 2023

@swift-ci please test source compatibility

@xedin
Copy link
Contributor Author

xedin commented Mar 29, 2023

Source compat failure is Doggie project UPASS unrelated to these changes.

@xedin xedin merged commit 5571de1 into swiftlang:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants