IRGen support for closures that capture metadata and witness table packs #64679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
varidic-generic-captures
branch
2 times, most recently
from
7d3e314 to
1be23c3
Compare
|
@swift-ci Please test |
This removes the "optimization" where a function type, metatype or tuple type was split up into structural components, because it seems that in general we need this structural type metadata again. Similarly, this no longer tries to split up dependent concrete conformances and instead passes the witness table in the context. This makes the context larger potentially, but it avoids calls to metadata access functions and swift_getWitnessTable() every time the closure is invoked.
slavapestov
force-pushed
the
varidic-generic-captures
branch
from
1be23c3 to
2d2b024
Compare
slavapestov
force-pushed
the
varidic-generic-captures
branch
from
2d2b024 to
8a6bb30
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.