-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Don't build and install libcxx when generating a macOS toolchain #64687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't build and install libcxx when generating a macOS toolchain #64687
Conversation
Libcxx is already part of the macOS SDKs shipped since Xcode 12.5, so there is no need for us to rebuild it. This will also prevent compilation issues in the presets that builds the standard library using a prebuilt toolchain, so the clang compiler that ships in that toolchain does not pickup libcxx headers that do not match the tbd shipped in the underlying macOS SDK. This change would be desirable for all macOS presets, focusing for now on the toolchain presets. Addresses rdar://106817494
@swift-ci please test |
@swift-ci please build toolchain |
I don't have any objections to the removal, but I am concerned that this might break the build. The LLDB builds and tests require that libc++ is built in order to test. Does this not impact that? |
Libcxx is already part of the macOS SDKs shipped since Xcode 12.5, so there is no need for us to rebuild it. This will also prevent compilation issues in the presets that builds the standard library using a prebuilt toolchain, so the clang compiler that ships in that toolchain does not pickup libcxx headers that do not match the tbd shipped in the underlying macOS SDK. This change would be desirable for all macOS presets, focusing for now on the toolchain presets. Addresses rdar://106817494 (cherry picked from commit 310082b, swiftlang#64687)
From what I can tell, it should not:
That suggests to me that they already pulling libcxx content from the underlying macOS SDK
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macOS failure:
|
@swift-ci please test macOS |
Hit unrelated issue when running swiftpm tests
|
@swift-ci please test macOS |
Hitting another unrelated issue in https://ci.swift.org/job/swift-PR-macos/7344
|
@swift-ci please test macOS |
Libcxx is already part of the macOS SDKs shipped since Xcode 12.5, so there is no need for us to rebuild it.
This will also prevent compilation issues in the presets that builds the standard library using a prebuilt toolchain, so the clang compiler that ships in that toolchain does not pickup libcxx headers that do not match the tbd shipped in the underlying macOS SDK.
This change would be desirable for all macOS presets, focusing for now on the toolchain presets.
Addresses rdar://106817494