[Executors] Clean up how we unwrap the local executor of distributed custom actor #64719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-cleanup-hop-to-distributed-custom-executor
branch
from
ffbfdfd to
f0f0084
Compare
|
@swift-ci please smoke test |
slavapestov
approved these changes
Mar 29, 2023
ktoso
added
concurrency
etcwilde
pushed a commit
to etcwilde/swift
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation relied on a hacky
_protocol requirement.This is a proper implementation of the "we want to unwrap and offer a nice error" and removes the temporary workaround.
Thank you @slavapestov for the help here!