Tests: Fix and re-enable @_spi_available tests
#64724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkcsgexi
approved these changes
Mar 29, 2023
The main issue was that the tests specified `-library-level=api` in `swift-frontend` invocations instead of `-library-level api`. The former seems to have no effect and therefore expected diagnostics were not being emitted. Additional clean up: - Make every test require `OS=macosx` for ease of local testing. - Avoid unnecessarily specifying target arches (this makes tests slow). - Add missing `FileCheck` invocation. - Add some missing test coverage. Resolves rdar://91325474
tshortli
force-pushed
the
spi-available-tests
branch
from
46013a5 to
f4b7959
Compare
|
@swift-ci please test |
xymus
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue was that the tests specified
-library-level=apiinswift-frontendinvocations instead of-library-level api. The former seems to have no effect and therefore expected diagnostics were not being emitted.Additional clean up:
OS=macosxfor ease of local testing.FileCheckinvocation.Resolves rdar://91325474