Create feature flag for SE-0384 #64730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
NuriAmari
force-pushed
the
fwd-declarations-feature-flag
branch
from
7cc7f2b to
564621e
Compare
|
@swift-ci Please test |
allevato
reviewed
Mar 29, 2023
| @@ -3159,6 +3159,24 @@ static bool usesFeatureExistentialAny(Decl *decl) { | |||
| return false; | |||
| } | |||
|
|
|||
| static bool usesFeatureImportObjcForwardDeclarations(Decl *decl) { | |||
There was a problem hiding this comment.
Is this being used for anything? I don't see it referenced elsewhere in this PR.
There was a problem hiding this comment.
Yes, but not obviously -- above in the same file:
#define LANGUAGE_FEATURE(FeatureName, SENumber, Description, Option) \
if (usesFeature##FeatureName(decl)) \
collectRequiredFeature(Feature::FeatureName, operation);
#define SUPPRESSIBLE_LANGUAGE_FEATURE(FeatureName, SENumber, Description, Option) \
if (usesFeature##FeatureName(decl)) \
collectSuppressibleFeature(Feature::FeatureName, operation);
#include "swift/Basic/Features.def"
}
};It won't compile without this.
There was a problem hiding this comment.
Ah, metaprogramming. Thanks for clarifying!
allevato
approved these changes
Mar 29, 2023
| @@ -3159,6 +3159,24 @@ static bool usesFeatureExistentialAny(Decl *decl) { | |||
| return false; | |||
| } | |||
|
|
|||
| static bool usesFeatureImportObjcForwardDeclarations(Decl *decl) { | |||
There was a problem hiding this comment.
Ah, metaprogramming. Thanks for clarifying!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.