Fix out-of-bounds when providing fixits for the @available attribute. #64734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristanlabelle
requested review from
hborla,
slavapestov and
xedin
as code owners
|
Please add a test case for this that triggered the failure case. |
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
My bad, pushed a fix |
|
@swift-ci please test |
|
@swift-ci please test |
tshortli
approved these changes
Mar 30, 2023
|
@swift-ci please clean test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an out-of-bounds iterator access when providing fixits for the @available attribute.
None of the code paths in
updateLabelsForArgshould execute once we've reached the end of theargumentLabelIDsvector, but not all cases tested for this.Fixes #64694