[Macros] Name lookup and type checking fixes for freestanding declaration macros #64761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s twice Instead of trying to work around a double-type-check of macro expansion declaration arguments, avoid type checking them twice in the first place. We're caching the `ResolveMacroRequest` output in a somewhat dodgy manner to account for the `MacroExpansionDecl`/`MacroExpansionExpr` cloning.
Teach ASTScope to create child nodes for each of the arguments of a macro expansion declaration, so that we can perform name lookup into them. Otherwise, we cannot have nontrivial closures in arguments to a macro expansion declaration. Fixes rdar://107388151.
Sometimes we build a `MacroExpansionDecl` from a `MacroExpansionExpr`. Sometimes we do it the other way. In both cases, we risk the two copies of must-by-shared data (macro arguments, resolved macro reference, etc.) getting out-of-sync. Instead, share the storage between the two representations when we create one from the other, so that they cannot get out-of-sync. This allows us to eliminate the extremely-dodgy `cacheOutput` call earlier.
|
@swift-ci please smoke test |
rxwei
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce two significant fixes for freestanding declaration macros:
Fixes rdar://107388151.